From: bsekisser <squirmyworms@embarqmail.com>
Date: Fri, 17 Oct 2014 12:29:55 +0000 (-0400)
Subject: core: Removal of duplicate code...
X-Git-Tag: v1.3~53^2
X-Git-Url: https://git.htl-mechatronik.at/public/?a=commitdiff_plain;h=709a87bb91ba11c52ad83de3554522664f928d02;p=sx%2Fsimavr.git

core: Removal of duplicate code...

core contains two functionally equivalent blocks of code...  implimenting
	cl?, se? and bclr, bset.   During operation the case code for
	bclr and bset never get called, but as stated does not matter since
	code at the top of the block performs the EXACT same function.
	technically... using the case code SHOULD be the better performing
	option...  at the moment though, neither one seems to exhibiting
	any advantage over the other.

	modified:   simavr/sim/sim_core.c
---

diff --git a/simavr/sim/sim_core.c b/simavr/sim/sim_core.c
index c4e7b3e..aa3446c 100644
--- a/simavr/sim/sim_core.c
+++ b/simavr/sim/sim_core.c
@@ -953,22 +953,6 @@ run_one_again:
 					cycle += 2; // 3 cycles
 					_avr_set_r(avr, 0, avr->flash[z]);
 				}	break;
-				case 0x9408:case 0x9418:case 0x9428:case 0x9438:case 0x9448:case 0x9458:case 0x9468:
-				case 0x9478:
-				{	// BSET -- Set Bit in SREG -- 1001 0100 0bbb 1000
-					get_sreg_bit(opcode);
-					avr->sreg[b] = 1;
-					STATE("bset %c\n", _sreg_bit_name[b]);
-					SREG();
-				}	break;
-				case 0x9488:case 0x9498:case 0x94a8:case 0x94b8:case 0x94c8:case 0x94d8:case 0x94e8:
-				case 0x94f8:	// bit 7 is 'clear vs set'
-				{	// BCLR -- Clear Bit in SREG -- 1001 0100 1bbb 1000
-					get_sreg_bit(opcode);
-					avr->sreg[b] = 0;
-					STATE("bclr %c\n", _sreg_bit_name[b]);
-					SREG();
-				}	break;
 				default:  {
 					switch (opcode & 0xfe0f) {
 						case 0x9000: {	// LDS -- Load Direct from Data Space, 32 bits -- 1001 0000 0000 0000