From fddb2a02e9feadaefaf690b07a69a1556fb96fd1 Mon Sep 17 00:00:00 2001 From: Jakob Gruber Date: Fri, 20 Jul 2012 14:19:48 +0200 Subject: [PATCH] examples: hd44780 responds on falling edge of E pin The example itself works both ways, but the actual HD44780 chip processes data on the falling edge - see the data sheet. --- examples/parts/hd44780.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/parts/hd44780.c b/examples/parts/hd44780.c index 144cbfc..8fe194c 100644 --- a/examples/parts/hd44780.c +++ b/examples/parts/hd44780.c @@ -340,8 +340,8 @@ hd44780_pin_changed_hook( b->pinstate = (b->pinstate & ~(1 << irq->irq)) | (value << irq->irq); int eo = old & (1 << IRQ_HD44780_E); int e = b->pinstate & (1 << IRQ_HD44780_E); - // on the E pin rising edge, do stuff otherwise just exit - if (!eo && e) + // on the E pin falling edge, do stuff otherwise just exit + if (eo && !e) avr_cycle_timer_register(b->avr, 1, _hd44780_process_e_pinchange, b); } -- 2.39.5